Repository navigation
[dead-code] chore: remove dead functions — 2 functions removed - #71454
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
There was a problem hiding this comment.
🟡 Changes recommended
The deleted inventory tests cover active health-reporting behavior and should be adapted rather than removed.
1 open issue
What changed in this PR
Removes two unused internal helpers from the gh-aw CLI as a dead-code cleanup.
Changes:
- Deletes
listHealthFailureInventoryandparseRepoFromURL. - Removes three associated tests and unused test imports.
| File | Description |
|---|---|
pkg/cli/outcome_eval.go |
Removes the unused repository URL parser. |
pkg/cli/outcome_eval_test.go |
Removes the parser’s test. |
pkg/cli/health_payload_inventory_test.go |
Removes two inventory tests and their unused imports. |
pkg/cli/health_failures_first.go |
Removes the inventory wrapper while retaining its implementation. |
Review effort: Max
| assert.False(t, collection.Partial) | ||
| } | ||
|
|
||
| func TestHealthPayloadSignalsSurviveInventoryBudgetExhaustion(t *testing.T) { |
|
🎉 This pull request is included in a new release. Release: |
Functions Removed
listHealthFailureInventorypkg/cli/health_failures_first.goparseRepoFromURLpkg/cli/outcome_eval.goTests Removed
TestParseRepoFromURLTestHealthPayloadInventoryFindsFleetSignalsWithoutEnrichmentTestHealthFailureInventoryStopsWhenEveryWorkflowHasEnoughCandidatesVerification
go build ./...go vet ./...go vet -tags=integration ./pkg/cli/make fmt(JS prettier unavailable in the sandbox;gofmtclean)https://github.com/github/gh-aw/actions/runs/39969325485