Repository navigation
refactor: reduce complexity of apply_codemod in 0001_repos_unified - #2351
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply_codemodinsrc/compile/codemods/0001_repos_unified.rswas flagged byclippy::too_many_lines(131/100). Clippy's cognitive-complexity lint reported nothing.Changes
parse_repositories, which validates therepositories:shape.parse_checkout_aliases, which validates thecheckout:entries.convert_repository, which converts one legacy entry to arepos:entry. It also works out thecheckoutflag, and the nested if/else chain is now a singlefilter.Behaviour and error messages are unchanged.
Verification
cargo test --bin ado-aw codemods: 85 passed.cargo clippy --all-targets --all-features -- -W clippy::too_many_lines:apply_codemodis no longer flagged.