Repository navigation
refactor: reduce complexity of execute_impl in create_git_tag.rs - #2376
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No function tripped
cognitive_complexity, so I usedclippy::too_many_linesinstead.CreateGitTagResult::execute_implwas flagged at 122 lines against the limit of 100.I split three blocks out of it into private helpers:
check_policycovers the tag-pattern and allowed-repositories checks.build_tag_messagebuilds the message with the optional prefix.handle_responsehandles the success and failure HTTP responses.Behaviour is unchanged. After the refactor,
execute_implno longer shows up undertoo_many_lines. The 14create_git_tagtests pass. I ran only that test filter, not the fullcargo test. I also re-ran clippy withtoo_many_linesand nothing is flagged forcreate_git_tag.rs.