Repository navigation
refactor: reduce complexity of summarize_step in src/compile/ir/summary.rs - #2383
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summarize_stepwas flagged byclippy::too_many_lines(128/100): it built an 8-element tuple per step variant, repeating condition/env-ref handling in each arm, then patchedauto_is_outputinline.Changes (behaviour-preserving):
StepSummarydirectly per variant, using a localbareconstructor plus struct update syntax.summarize_conditionclosure.summarize_env_refsandmark_auto_is_outputhelpers (flattened with let-else).Before/after:
too_many_lines128/100 → no longer flagged.cognitive_complexityflagged nothing at the default threshold.Validation:
cargo testpassed (3410 unit tests plus integration tests, 0 failed). Clippy with-W clippy::too_many_linesno longer flagssummarize_step.Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
releaseassets.githubusercontent.comspsprodeus21.vssps.visualstudio.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.