Skip to content

refactor: reduce complexity of execute_impl in link_work_items - #2389

Draft
github-actions[bot] wants to merge 1 commit into
mainfrom
refactor/reduce-complexity-link-work-items-execute-impl-1db831c11da454d8
Draft

github-actions[bot] wants to merge 1 commit into
mainfrom
refactor/reduce-complexity-link-work-items-execute-impl-1db831c11da454d8

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

LinkWorkItemsResult::execute_impl in src/safe_outputs/link_work_items.rs mixed target-scope validation, JSON Patch construction and the HTTP call in one function.

Changes (behaviour-preserving)

  • Extracted check_target_scope(), which returns the failure message for target-scope violations.
  • Extracted build_patch_doc(), which builds the JSON Patch relation document.

Complexity (clippy::too_many_lines): 150/100 → 124/100. The function is still over the threshold, but the validation logic now sits in separate, easier-to-read helpers.

Validation

  • cargo test --bin ado-aw link_work_items: passed (15 passed, 0 failed).
  • rustfmt --check on the changed file: clean.
  • I did not run the full cargo test suite.

Generated by Cyclomatic Complexity Reducer · auto · 27 AIC · ⊞ 11.1K · ◷

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants