Skip to content

Use Git Data API for files #889

Open

Description

@Rexogamer

This would allow us to get files up to 100mb in size.

Activity

  1. chinesedfan commented on Sep 27, 2019

    @chinesedfan
    Member

    Thanks for your suggestion. But how do users view such large files? It is hard to navigate to certain lines or do anything else.

  2. Rexogamer commented on Sep 27, 2019

    @Rexogamer
    Author

    ...I don’t really see what that has to do with this...

    Currently, we can only get file that are up to 1MB in size using the GitHub API, but if we used this API, we could get bigger files. How is it hard to navigate? Please elaborate.

  3. chinesedfan commented on Sep 27, 2019

    @chinesedfan
    Member

    I mean files that are larger than 1mb must contain thousands or more lines of codes. So even if we load them, users can't read them.

    Can you provide a large file example? Like the file path in a repository. And what do you expect for which screen? The file list or the file detail?

  4. Rexogamer commented on Sep 27, 2019

    @Rexogamer
    Author

    This is simply an API change. No UI changes were requested in this issue, if that was what you were asking.

    When I try to load this file,, I get the following error:
    794A202B-D2B8-47AD-9B18-81BC13E479F0

  5. Rexogamer commented on Sep 27, 2019

    @Rexogamer
    Author

    When you say “users can’t read them”, are you suggesting the client would be laggy, or about screen size, or something else?

  6. chinesedfan commented on Sep 28, 2019

    @chinesedfan
    Member

    When you say “users can’t read them”, are you suggesting the client would be laggy, or about screen size, or something else?

    Yes. I admit that the current behavior is not the best one. If we updated the API without UI enhancements to handle large files, users may face new problems.

  7. Rexogamer commented on Sep 28, 2019

    @Rexogamer
    Author

    We don’t and won’t know what those issues are until we try the API change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions