Skip to content

os: return ErrClosed from deadline and directory methods - #82290

Open
gomaja wants to merge 1 commit into
golang:masterfrom
gomaja:os-closed-file-errclosed
Open

gomaja wants to merge 1 commit into
golang:masterfrom
gomaja:os-closed-file-errclosed

Conversation

@gomaja

@gomaja gomaja commented Oct 17, 2026

Copy link
Copy Markdown

On systems other than Plan 9, SetDeadline, SetReadDeadline and
SetWriteDeadline return the poll.FD error as is, so on a closed File
they return internal/poll's ErrFileClosing instead of ErrClosed.
ReadDir, Readdir and Readdirnames put the same error in a PathError
without converting it, except on Windows and Plan 9.

Convert it to ErrClosed, as wrapErr does for the other methods. The
deadline setters still return other errors, such as ErrNoDeadline,
unwrapped. On darwin, name the operation "readdir" when OpenDir reports
no system call, as for a closed File, instead of leaving it empty.

CL 849466 makes the same change for the RawConn methods.

For #82229

On systems other than Plan 9, SetDeadline, SetReadDeadline and
SetWriteDeadline return the poll.FD error as is, so on a closed File
they return internal/poll's ErrFileClosing instead of ErrClosed.
ReadDir, Readdir and Readdirnames put the same error in a PathError
without converting it, except on Windows and Plan 9.

Convert it to ErrClosed, as wrapErr does for the other methods. The
deadline setters still return other errors, such as ErrNoDeadline,
unwrapped. On darwin, name the operation "readdir" when OpenDir reports
no system call, as for a closed File, instead of leaving it empty.

CL 849466 makes the same change for the RawConn methods.

For golang#82229
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 7a368f7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/849970.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/849970.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants