Repository navigation
Conversation
On systems other than Plan 9, SetDeadline, SetReadDeadline and SetWriteDeadline return the poll.FD error as is, so on a closed File they return internal/poll's ErrFileClosing instead of ErrClosed. ReadDir, Readdir and Readdirnames put the same error in a PathError without converting it, except on Windows and Plan 9. Convert it to ErrClosed, as wrapErr does for the other methods. The deadline setters still return other errors, such as ErrNoDeadline, unwrapped. On darwin, name the operation "readdir" when OpenDir reports no system call, as for a closed File, instead of leaving it empty. CL 849466 makes the same change for the RawConn methods. For golang#82229
Contributor
|
This PR (HEAD: 7a368f7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/849970. Important tips:
|
Contributor
|
Message from Ian Lance Taylor: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/849970. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On systems other than Plan 9, SetDeadline, SetReadDeadline and
SetWriteDeadline return the poll.FD error as is, so on a closed File
they return internal/poll's ErrFileClosing instead of ErrClosed.
ReadDir, Readdir and Readdirnames put the same error in a PathError
without converting it, except on Windows and Plan 9.
Convert it to ErrClosed, as wrapErr does for the other methods. The
deadline setters still return other errors, such as ErrNoDeadline,
unwrapped. On darwin, name the operation "readdir" when OpenDir reports
no system call, as for a closed File, instead of leaving it empty.
CL 849466 makes the same change for the RawConn methods.
For #82229