Skip to content

test: validate signature-gated confirmation as a user-message plugin - #7783

Open
pavancharak wants to merge 1 commit into
google:mainfrom
pavancharak:signed-confirmation-validation
Open

pavancharak wants to merge 1 commit into
google:mainfrom
pavancharak:signed-confirmation-validation

Conversation

@pavancharak

Copy link
Copy Markdown

Adds a prototype plugin that verifies a detached Ed25519 signature over the confirmation call ID and decision in on_user_message_callback. An approval without a valid signature from the approver key is rewritten to confirmed=False before the confirmation processor sees it.

Six tests cover forged, wrong-key, decision-flip, cross-call, valid, and decline cases.

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

Adds a prototype plugin that verifies a detached Ed25519 signature over
the confirmation call ID and decision in on_user_message_callback. An
approval without a valid signature from the approver key is rewritten to
confirmed=False before the confirmation processor sees it.

Six tests cover forged, wrong-key, decision-flip, cross-call, valid, and
decline cases.

Signed-off-by: pavancharak <charak1987@gmail.com>
@google-cla

google-cla Bot commented Oct 28, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants