Repository navigation
Fix memenv RenameFile when source and target are the same - #1376
Open
Huang-404-Q wants to merge 1 commit into
Open
Huang-404-Q wants to merge 1 commit into
Huang-404-Q wants to merge 1 commit into
Conversation
InMemoryEnv::RenameFile removes the target before copying the source entry, so renaming a file to itself deletes it while returning OK. POSIX rename(2) with identical paths is a successful no-op that preserves the file. Return OK before touching the map when src == target, and add a test that checks the file still exists with its original size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InMemoryEnv::RenameFile(src, target)removes the target before copying the source entry, so whensrc == targetit deletes the only map entry and then re-inserts nothing. The call returns OK, but the file is gone. POSIXrename(2)with identical paths is a successful no-op that preserves the file.Repro (added as
MemEnvTest.RenameFileToItself):Fix: return OK before touching the map when
src == target.Verification (MinGW, CMake + Ninja):
Without the fix the test fails (
FileExistsis false); with it,MemEnvTest.*passes 8/8. No existing open PR toucheshelpers/memenv.