Skip to content

Make prepareRelease output deterministic - #934

Open
ngnatng wants to merge 1 commit into
mainfrom
fix_release_diff_noise
Open

ngnatng wants to merge 1 commit into
mainfrom
fix_release_diff_noise

Conversation

@ngnatng

@ngnatng ngnatng commented Nov 13, 2026

Copy link
Copy Markdown

prepareRelease produced noisy diffs by reordering files:

  • updateVersion rewrote gradle.properties with Properties.store(), which reorders keys and adds a timestamp. It now replaces only the version line.
  • The license-report plugin writes dependencies in HashSet order, which changes between runs. generateLicenses now re-renders its by-dependency reports with the plugin's own LicenseReporter, sorted by dependency name.

third_party/LICENSES.* are regenerated in sorted order; their contents are unchanged.

prepareRelease produced diffs unrelated to the release:

- updateVersion rewrote gradle.properties with Properties.store(), which
  reorders keys and adds a timestamp. It now replaces only the version line.
- The license-report plugin writes dependencies in HashSet order, which
  changes between runs. generateLicenses now re-renders its by-dependency
  reports with the plugin's own LicenseReporter, sorted by dependency name.

third_party/LICENSES.* are regenerated in sorted order; their contents are
unchanged.
@ngnatng
ngnatng requested review from a team as code owners November 13, 2026 21:19
@ngnatng ngnatng changed the title Make release prep output deterministic Make prepareRelease output deterministic Nov 13, 2026
@ngnatng
ngnatng requested review from Raibaz and removed request for sundquist November 13, 2026 21:20
@jradcliff

Copy link
Copy Markdown
Member

@ngnatng , could you rebase or merge to bring this branch up to date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants