Skip to content

fix: split port from google.api.default_host into DEFAULT_SERVICE_PORT - #889

Merged
bshaffer merged 2 commits into
mainfrom
fix/default-host-port
Oct 12, 2026
Merged

bshaffer merged 2 commits into
mainfrom
fix/default-host-port

Conversation

@bshaffer

@bshaffer bshaffer commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

see googleapis/google-cloud-php#9776

When google.api.default_host includes a port (such as localhost:7469 in gapic-showcase or library-example.googleapis.com:1234), split the host and port across SERVICE_ADDRESS and DEFAULT_SERVICE_PORT instead of leaving the port in SERVICE_ADDRESS and appending :443.

@bshaffer
bshaffer requested a review from a team as a code owner October 7, 2026 22:13
@snippet-bot

snippet-bot Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bshaffer
bshaffer enabled auto-merge (squash) October 12, 2026 20:45
@bshaffer
bshaffer merged commit 1d02867 into main Oct 12, 2026
15 checks passed
@bshaffer
bshaffer deleted the fix/default-host-port branch October 12, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants