Repository navigation
fix: fall back to resumable upload method allowlist when getMediaUpload is unset - #902
Open
viacheslav-rostovtsev wants to merge 1 commit into
Conversation
…ad is unset Un-nest the hardcoded RPC/package allowlist in MethodDetails::maybeCreateResumableUpload from the else block so it runs whenever $isMediaUpload evaluates to false. Otherwise, once google/common-protos exposes HttpRule::getMediaUpload(), allowlisted RPCs whose protos do not yet set the media_upload option return null from getMediaUpload() and skip the allowlist fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Un-nests the RPC/package allowlist fallback in
MethodDetails::maybeCreateResumableUploadout of theelseblock so it executes whenever$isMediaUploadevaluates tofalse, regardless of whetherHttpRule::getMediaUpload()exists on the loadedgoogle/common-protosclass.Without this change, once
google/common-protospublishesHttpRule::getMediaUpload(), allowlisted RPCs whose service protos do not yet set themedia_uploadannotation returnnullfrom$httpRule->getMediaUpload(), evaluate$isMediaUploadtofalse, and bypass the allowlist fallback (regressing to normal unary RPC generation).