Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

Turn REST response exceptions into GoogleAPICallError #769

Closed
#891
Closed
Turn REST response exceptions into GoogleAPICallError#769
#891
Assignees
yon-mg
Labels
type: cleanupAn internal cleanup or hygiene concern.

Description

@busunkim96
busunkim96
opened on Feb 5, 2021

Currently the REST transport uses response.raise_for_status() and returns the exception object from requests.

gapic-generator-python/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2

Line 206 in cc55a18

response.raise_for_status()

For consistency with existing libraries the response should be converted into a GoogleAPICallError.

https://github.com/googleapis/python-api-core/blob/db48ea3f8f69cd5039cdc2e35a0a3604d731bc70/google/api_core/exceptions.py#L399

Activity

  1. busunkim96
    assigned
    yon-mg
    on Feb 5, 2021
  2. yoshi-automation
    added
    triage meI really want to be triaged.
    on Feb 5, 2021

  3. yon-mg commented on Feb 5, 2021

    @yon-mg
    yon-mg
    on Feb 5, 2021
    Contributor

    Addressed in upcoming pr.

  4. busunkim96
    added
    type: cleanupAn internal cleanup or hygiene concern.
    and removed
    triage meI really want to be triaged.
    on Feb 5, 2021
  5. vchudnov-g
    closed this as completedin #891on May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions