Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Auth libraries dependency problem fix - #310

Merged
vam-google merged 2 commits into
googleapis:masterfrom
vam-google:master
May 23, 2017
Merged

vam-google merged 2 commits into
googleapis:masterfrom
vam-google:master

Conversation

@vam-google

Copy link
Copy Markdown
Contributor

@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

LGTM

@codecov-io

codecov-io commented May 23, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #310 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #310      +/-   ##
============================================
- Coverage     69.98%   69.93%   -0.06%     
  Complexity      352      352              
============================================
  Files            72       72              
  Lines          1906     1906              
  Branches        155      155              
============================================
- Hits           1334     1333       -1     
- Misses          505      506       +1     
  Partials         67       67
Impacted Files Coverage Δ Complexity Δ
...java/com/google/api/gax/grpc/RetryingCallable.java 85.18% <0%> (-1.86%) 6% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5830ace...0b5b9b7. Read the comment docs.

@shinfan

shinfan commented May 23, 2017

Copy link
Copy Markdown
Contributor

LGTM

io.grpc:grpc-auth:1.2.0 is also depending on 0.4.0. We may need to ask the gRPC team to update as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants