Repository navigation
Serializing Spanner Mutations #1871
Description
For Apache Beam support we need to serialize/deserialize Mutations. See apache/beam#2166
Few options
- Make Mutation#toProto public https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Mutation.java#L337 and add corresponding fromProto method.
- Make Mutation serializable and implement writeObject/readObject
- Introduce a new class, move Mutation#toProto code there and implement fromProto.
Activity
vkedia commentedon Apr 6, 2017
I would prefer making Mutation serializable. That seems more idiomatic to me.
@garrettjonesgoogle is there any precedence for this? Do you have any preference?
garrettjonesgoogle commentedon Apr 6, 2017
Serialization is used widely in google-cloud-java, so it seems like a good idea here.
mairbek commentedon Apr 19, 2017
I've opened a PR #1939.
This turned out to be harder than I've expected, because type information is lost once spanner Mutation is converted to the Mutation proto.
vkedia commentedon Apr 21, 2017
Closed by PR #1952
chore(main): release 2.29.2-SNAPSHOT (#1871)
chore(main): release 2.29.2-SNAPSHOT (#1871)
docs: add sample for using array of struct query param (googleapis#1871)
chore(main): release 2.25.3 (googleapis#1877)
chore: Remove Code Coverage requirements (#1871)
fix(oauth2): mask sensitive tokens in HTTP logs (#1900)
chore(main): release 1.126.1 (#1871)
chore(main): release 1.126.1 (#1871)
deps: update dependency com.google.cloud:sdk-platform-java-config to …
chore: Revert "chore: setup 2.23.x lts branch (googleapis#1852)" (goo…