Skip to content

Pull should set return_immediately to false #2108

Closed

Description

@pongad

This came out of a discussion with Pubsub team.

cc @haakonringberg

Activity

  1. self-assigned this
    on Jun 1, 2017
  2. garrettjonesgoogle commented on Jun 2, 2017

    @garrettjonesgoogle
    Contributor

    @pongad can you provide more context?

  3. added
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on Jun 2, 2017
  4. pongad commented on Jun 5, 2017

    @pongad
    ContributorAuthor

    Slightly edited the description. IIUC, it saves RPC calls, but @haakonringberg can probably provide better details than I can.

  5. haakonringberg commented on Jun 5, 2017

    @haakonringberg

    We now always discourage the use of return_immediately (it's an option we shouldn't have provided in the API). It's misleading (e.g., what does "immediately" mean in the context of a backlog?) and hurts throughput.

  6. added a commit that references this issue on Jun 6, 2017
    19cc97d
  7. added a commit that references this issue on May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: pubsubIssues related to the Pub/Sub API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions