Repository navigation
Suggestion : Improvement of String.equals("xxx") #4320
Description
Hi,
I have found some usage of “String.equals("xxx")” in this project.
When using string.equals("a") ，it will get nullpointexception if string ==null.
The problem can be fixed by repalced with "a".equals(string) or Objects.equals(string,"a").
Detail websites and lines are listed below
77 80 83 86 89 92 95 98 101 104 | https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-compute/src/main/java/com/google/cloud/compute/v1/InsertTargetTcpProxyHttpRequest.java
There are too many cases of "fieldName.equals("xxxxx")" .
Best regards
Activity
andreamlin commentedon Jan 11, 2019
Hi @o0lwj0o (what a username!), thanks a lot for filing this bug. Indeed this is a problem, and it should be easily fixed.
andreamlin commentedon Jan 11, 2019
This fix will be available in the next release of google-cloud-compute.
andreamlin commentedon Jan 18, 2019
Update: this is now in master: f62e169 and in the 0.78-alpha release.
Thanks again for pointing this out @o0lwj0o !
chore: replace old java team with cloud-sdk-java-team (#4320)