Repository navigation
Add AckDeadlineRenewer class for automatic ack deadline renewal - #1031
Merged
Merged
Conversation
googlebot
added
the
cla: yes
mziccard
force-pushed
the
pubsub-renewer
branch
2 times, most recently
from
May 27, 2016 18:59
681108a to
d4f296e
Compare
commented
May 27, 2016
Contributor
Author
|
/cc @aozarov |
| * {@link #add(String, Iterable)}. The acknowledge deadlines of added messages are renewed until the | ||
| * messages are explicitly removed using {@link #remove(String, String)}. | ||
| */ | ||
| class AckDeadlineRenewer implements AutoCloseable { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
commented
Jun 1, 2016
Contributor
Author
commented
Jun 1, 2016
commented
Jun 1, 2016
| } | ||
| for (Map.Entry<String, List<String>> entry : Multimaps.asMap(messagesToRenewNext).entrySet()) { | ||
| // We send all ack deadline renewals for a subscription | ||
| pubsub.modifyAckDeadlineAsync(entry.getKey(), MIN_DEADLINE_MILLIS, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
commented
Jun 1, 2016
Contributor
|
Change looks good. Implementation looks good and api looks good (I provided one more minor suggestion). Maybe @lesv want to go over this code as well (I didn't pay attention to anything but API and impl). |
| super(PubSubFactory.class, PubSubRpcFactory.class, builder); | ||
| } | ||
|
|
||
| @Override |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
commented
Jun 2, 2016
commented
Jun 3, 2016
Contributor
Author
|
I am merging this, if @lesv has some more comments I'd be happy to address them in separate PRs. |
commented
Jun 6, 2016
Contributor
|
I'm happy with this change. |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simpler version of #1024 to provide support for automatic ack deadline renewals