Skip to content

Storage non-resumable uploads fail #2050

New issue
New issue
Closed
Closed
Storage non-resumable uploads fail#2050
Assignees
stephenplusplus
Labels
api: storageIssues related to the Cloud Storage API.coretype: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@ddunkin
ddunkin
opened on Mar 5, 2017

Storage non-resumable uploads fail when used with @google-cloud/common 0.12.1. The error message is:

UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Sorry, we cannot connect to Cloud Services without a project ID. You may specify one with an environment variable named "GCLOUD_PROJECT". See https://googlecloudplatform.github.io/google-cloud-node/#/docs/guides/authentication for a detailed guide on creating an authenticated connection.

The error message is misleading. The code mistakenly assumes any error thrown util.makeAuthenticatedRequestFactory -> makeAuthenticatedRequest -> onAuthenticated is because of a missing project ID.

The bug that causes the error was introduced by #1990. hasOwnProperty is called on an object that does not have that function. An alternative implementation would be to call Object.hasOwnProperty.call(value, opt) instead of value.hasOwnProperty(opt).

Environment details

  • OS: macOS, Linux
  • Node.js version: 6.x
  • npm version: 3.x
  • google-cloud-node version: 0.47.0

Steps to reproduce

  1. require google-cloud
  2. storage.bucket('my-bucket').upload('file.txt', { resumable: false })

Activity

  1. stephenplusplus
    added
    api: storageIssues related to the Cloud Storage API.
    core
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Mar 6, 2017
  2. stephenplusplus
    closed this as completedin a1edaabon Mar 6, 2017

  3. stephenplusplus commented on Mar 6, 2017

    @stephenplusplus
    stephenplusplus
    on Mar 6, 2017
    Contributor

    Thank you for catching this and debugging it! I just put through a fix: a1edaab -- does this look good?

  4. andrewolobo commented on Mar 13, 2017

    @andrewolobo
    andrewolobo
    on Mar 13, 2017

    This bug is still active. google-cloud-node version:"0.7.0", default storage.bucket('my-bucket').upload('file.txt') does not upload .Must explicitly add resumable flag for upload storage.bucket('my-bucket').upload('file.txt', { resumable: true }) .

  5. stephenplusplus commented on Mar 14, 2017

    @stephenplusplus
    stephenplusplus
    on Mar 14, 2017
    Contributor

    This code works for me with @google-cloud/storage@0.7.0:

    var storage = require('@google-cloud/storage')()
var bucket = storage.bucket('stephen-has-a-new-bucket')

bucket.upload('package.json', console.log) // no error

    Can you make sure you rm -rf node_modules && npm install --save @google-cloud/storage@^0.7.0 and let me know if it persists? If you can, a reproducible test gist that I can clone, install, and run to see the crash would help.

  6. JustinBeckwith
    assigned
    stephenplusplus
    on Feb 1, 2021
  7. sofisl
    added 3 commits that reference this issue on Feb 24, 2026

    build: update gapic generator to allow individual location mixin gene…

    99a0ebd

    chore(main): release 6.4.2 (#2050)

    57fe697

    chore(spanner): regenerate proto files (#2050)

    96a3137
  8. GautamSharda
    added 2 commits that reference this issue on Mar 11, 2026

    chore: update NodeJS post-processor to use MOSS approved images and u…

    f8508ea

    core: (util) correct object recursion during projectId insertion

    3584252
  9. sofisl
    added 2 commits that reference this issue on Mar 17, 2026

    chore(deps): upgrade sinon to 21 (#2050)

    885fce5

    feat: X509 cert authentication (#2055)

    eec91f4
  10. thiyaguk09
    added a commit that references this issue on Mar 18, 2026

    chore(main): release 6.4.2 (googleapis#2050)

    a6e5dcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: storageIssues related to the Cloud Storage API.coretype: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions