You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to #377 (comment) the suggested way of publishing and pulling messages is now through these methods on top of our existing publish and pull methods. We can just rework publish to support an array of messages and always use publishBatch API call behind the scenes. Similarly, pull right now returns 1 message so we can either use maxEvents: 1 by default to maintain backward compatibility or we can pull many messages, and document the new maxEvents option. Thoughts?
Just accepting an array to publish is a great idea. Same for pull; just accept an object with maxCount (instead of maxEvents?) that if absent, will default to 1/current behavior. 👍
Activity
[-]Implement publishBatch method[/-][+]Implement publishBatch and pullBatch methods[/+]ryanseys commentedon Feb 5, 2015
According to #377 (comment) the suggested way of publishing and pulling messages is now through these methods on top of our existing publish and pull methods. We can just rework
publishto support an array of messages and always usepublishBatchAPI call behind the scenes. Similarly,pullright now returns 1 message so we can either usemaxEvents: 1by default to maintain backward compatibility or we can pull many messages, and document the new maxEvents option. Thoughts?stephenplusplus commentedon Feb 9, 2015
Just accepting an array to
publishis a great idea. Same forpull; just accept an object withmaxCount(instead ofmaxEvents?) that if absent, will default to 1/current behavior. 👍I'd like to promote the priority of this one, since it breaks every build (which is now 3 builds to account for each supported platform) - https://travis-ci.org/GoogleCloudPlatform/gcloud-node/jobs/50067298
ryanseys commentedon Feb 9, 2015
SGTM, if you'd like to jump at this one, be my guest. I'm a little occupied this morning.
stephenplusplus commentedon Feb 9, 2015
On it 👍
chore: update cloud rad kokoro build job (#379)
chore: remove unused dev packages (#379)
build: move system and samples test from Node 10 to Node 12 (#379)
19 remaining items
docs: update import syntax in jsdoc (#379)
build: remove unused codecov config (#379)
chore(deps): update dependency @types/sinon to v7.0.3 (#379)
chore(deps): update dependency @types/sinon to v7.0.3 (#379)
chore(deps): update dependency @types/sinon to v7.0.3 (#379)
refactor: wrap execSync with encoding: utf-8 (#379)
refactor: wrap execSync with encoding: utf-8 (#379)
refactor: wrap execSync with encoding: utf-8 (#379)
Convert Index and WriteBatch (#379)
docs: add lint/fix example to contributing guide (#379)
chore: migrate code from googleapis/gcp-metadata (#53)
docs: update readme badges (#379)
docs: update readme badges (#379)
docs: update readme badges (#379)
docs: update readme badges (googleapis#379)