Repository navigation
Transaction Documentation #623
Description
Related: #621
Should we privatize transaction#begin and transaction#commit, removing them from the public docs and their usage in other Transaction examples?
A user goes through their Dataset instance to get a Transaction:
dataset.runInTransaction(transaction, done) {});This calls transaction.begin immediately, and the done function returned to their callback is actually transaction.commit.
Having these methods appear in the docs is probably quite confusing, as the user shouldn't need (or be able to) begin a transaction that already began, or commit the transaction before calling done (commit) again.
Activity
abelino commentedon May 22, 2015
Ohhh snap, this clears things up a lot!!! Thanks!!!
ryanseys commentedon May 22, 2015
Yeah these should be private.
ryanseys commentedon May 26, 2015
Oooh I'll address these in #627
chore(deps): update dependency sinon to v14 (#623)
chore: added extra variables owlbot kokoro configs (#623)
fix: make request optional in all cases (#623)
chore: release 3.1.3 (#624)
chore(deps): update dependency execa to v3 (#623)
chore(deps): update dependency @types/mocha to v9 (#623)
chore(deps): update dependency @types/mocha to v9 (#623)
build!: require node.js 10.x and up (#623)
build!: require node.js 10.x and up (#623)
build!: require node.js 10.x and up (#623)
build!: require node.js 10.x and up (#623)
build!: require node.js 10.x and up (#623)
chore: regenerate the code (#623)
migrate code from googleapis/cloud-profiler-nodejs (#7087)
chore(deps): update dependency @types/mocha to v9 (#623)
chore: regenerate the code (#623)
chore: regenerate the code (#623)
fix: Support more than 100 long-lived streams (#623)
build: use node10 to run samples-test, system-test etc (#623)
chore: use published jsdoc-baseline package (#623)
feat: support user-provided auth clients (#623)
build: use node10 to run samples-test, system-test etc (googleapis#623)