Repository navigation
Is the Datastore Query object supposed to be immutable? #731
Description
At first glance I assumed that the Query class was supposed to be immutable -- each method creates a new query instance, copies all of the properties from the previous instance and then returns it.
However, I noticed that for methods that can be called multiple times (filter() and order()) it holds a reference to the previous instance.
e.g.
var query1 = new Query(['kind1']);
var query2 = query1.filter('count >', 5);
query1.filters.length; // => 1Is this the desired functionality?
Activity
stephenplusplus commentedon Jul 20, 2015
No! If you have a chance to write those methods better, please do!
chore(main): release 3.3.0 (#731)
chore: release 1.14.2 (#731)
chore(main): release 5.1.3 (#731)
chore(main): release 5.1.3 (#731)
chore(main): release 5.1.3 (#731)
fix(deps): update dependency pprof to v3.1.0 (#731)
chore: release 4.1.2 (#734)
fix(deps): update dependency pprof to v3.1.0 (#731)
11 remaining items
chore: release 4.1.2 (#734)
fix(deps): update dependency pprof to v3.1.0 (#731)
chore: release 4.1.2 (#734)
chore(main): release 5.1.3 (#731)
chore(main): release 5.1.3 (#731)
migrate code from googleapis/cloud-profiler-nodejs (#7087)
docs: direct to documentation for datastore, not the product landing …
chore: update cloud-rad version to ^0.4.0 (#731)
docs: direct to documentation for datastore, not the product landing …
chore: update cloud-rad version to ^0.4.0 (#731)
chore: release 2.2.7 (#731)
chore: update cloud-rad version to ^0.4.0 (#731)
fix(docs): snippets are now replaced in jsdoc comments (#731)
build(test): adds support for build cop, fixes codecov.io (#731)
fix: pull projectId from auth client with emulator (#731)