Repository navigation
Conversation
Hectorhammett
approved these changes
Nov 5, 2026
# Conflicts: # Gax/composer.json # composer.json
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused
google/grpc-gcpdependency andgcpApiConfigPathclient option fromgoogle/gax.google/grpc-gcp(^0.5) was added in 2018 to support gRPC channel pooling and session affinity via*_grpc_config.jsonfiles when thesysvshmextension is loaded. However,gapic-generator-phphas never generated*_grpc_config.jsonfiles (only emitting a deadgcpApiConfigPathpath ingetClientDefaults()guarded byfile_exists()), and the only handwritten config in the SDK (spanner_grpc_config.json) was removed in Spanner V2 (#7840). Removing it drops an unmaintained pre-1.0 dependency that is already a no-op across all generated clients:google/grpc-gcpfromGax/composer.jsonand rootcomposer.jsongcpApiConfigPathhandling andinitGrpcGcpConfig()fromClientOptionsTraitGCPServerStreamCallfromServerStreamingCallWrapper