Skip to content

Core: google.cloud._helpers._default_service_project_id() does not use project ID from active configuration #2588

Closed

Description

@tswast

Problem (steps to reproduce)

Run gcloud init. Instead of updating the default configuration, make a new configuration (in my case, I called it "kittenbot"). Use a different project than you have for the default configuration. Note, you can switch between configurations using a command like: gcloud config configurations activate kittenbot.

Now, try to run any google-cloud-python library, notice that the paths it hit use project from the default configuration, not the active configuration. https://github.com/GoogleCloudPlatform/google-cloud-python/blob/ec781b6e8afc0b27599ddc69848571e1abf412ff/core/google/cloud/_helpers.py#L64 I noticed this problem because my GETs were failing in the RuntimeConfig, but it would be a worse problem with something like Datastore, where data could get written to the wrong project.

See similar issue in google-cloud-java: googleapis/google-cloud-java#827

This was fixed with: googleapis/google-cloud-java#831

Expected behavior

The default project should use the active configuration, not the default configuration.

Activity

  1. added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Oct 21, 2016
  2. dhermes commented on Oct 22, 2016

    @dhermes
    Contributor
  3. theacodes commented on Oct 25, 2016

    @theacodes
    Contributor

    Move this over to google-auth, it's getting closer and closer to ready.

    On Fri, Oct 21, 2016, 4:54 PM Tim Swast notifications@github.com wrote:

    Problem (steps to reproduce)

    Run gcloud init. Instead of updating the default configuration, make a
    new configuration (in my case, I called it "kittenbot"). Use a different
    project than you have for the default configuration. Note, you can switch
    between configurations using a command like: gcloud config configurations
    activate kittenbot.

    Now, try to run any google-cloud-python library, notice that the paths it
    hit use project from the default configuration, not the active
    configuration.
    https://github.com/GoogleCloudPlatform/google-cloud-python/blob/ec781b6e8afc0b27599ddc69848571e1abf412ff/core/google/cloud/_helpers.py#L64
    I noticed this problem because my GETs were failing in the RuntimeConfig,
    but it would be a worse problem with something like Datastore, where data
    could get written to the wrong project.

    See similar issue in google-cloud-java:
    googleapis/google-cloud-java#827
    googleapis/google-cloud-java#827

    This was fixed with: googleapis/google-cloud-java#831
    googleapis/google-cloud-java#831
    Expected behavior

    The default project should use the active configuration, not the default
    configuration.

    —
    You are receiving this because you are subscribed to this thread.
    Reply to this email directly, view it on GitHub
    #2588,
    or mute the thread
    https://github.com/notifications/unsubscribe-auth/AAPUc_NzSpMiRQiSCj1pgGTd5W4wUvk4ks5q2VC-gaJpZM4KdsN9
    .

  4. dhermes commented on Oct 25, 2016

    @dhermes
    Contributor

    w00t!

  5. theacodes commented on Oct 25, 2016

    @theacodes
    Contributor
  6. added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Apr 19, 2017
  7. dhermes commented on Aug 8, 2017

    @dhermes
    Contributor

    @jonparrott Is this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: corepriority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions