gRPC _Rendezvous w/ 'ABORTED' status propagated from 'Session.run_in_transaction' #3562

Activity

1. dhermes

   added

   api: spannerIssues related to the Spanner API.Issues related to the Spanner API.

   flaky

   on Jun 28, 2017
2. dhermes

   assigned

   tseaver

   on Jun 28, 2017
3. tseaver

   changed the title [-]Flaky Spanner system test[/-] [+]Unexpected 'ABORTED' error propagated from 'Session.run_in_transaction'[/+] on Jun 28, 2017
4. tseaver

   added

   gax

   grpc

   on Jun 28, 2017
5. tseaver commented on Jun 28, 2017

   

   tseaver

   on Jun 28, 2017

   Contributor

   More actions

   The code for Session.run_in_transaction expects that the ABORTED bit will be propagated as an instance of google.gax.errors.GaxError: somehow, the underlying GAPIC code is raising a gRCP _Rendezvous instead.
6. tseaver

   changed the title [-]Unexpected 'ABORTED' error propagated from 'Session.run_in_transaction'[/-] [+]gRPC _Rendezvous w/ 'ABORTED' status propagated from 'Session.run_in_transaction'[/+] on Jun 28, 2017
7. tseaver commented on Jun 28, 2017

   

   tseaver

   on Jun 28, 2017

   Contributor

   More actions

   @lukesneeringer Do we need to be regenerating the GAPIC code?
8. volokluev commented on Jul 20, 2017

   

   volokluev

   on Jul 20, 2017

   More actions

   Hi this is very annoying, to have a whole bunch of exceptions thrown in my application whenever a transaction is aborted. Is there any workaround to this issue at the moment?
9. tseaver commented on Jul 25, 2017

   

   tseaver

   on Jul 25, 2017

   Contributor

   More actions

   @vladkluev I'm hopeful we will have a fix pushed out shortly (this bug blocks PR #3663).
10. tseaver commented on Jul 25, 2017

    

    tseaver

    on Jul 25, 2017

    Last edited by tseaver

    Contributor

    More actions

    So, the issue is that the streaming_read and execute_streaming_sql calls are propagating the _Rendezvous error, rather than wrapping them up in a GaxError as the commit call does.
11. bjwatson

    added

    priority: p0Highest priority. Critical issue. P0 implies highest priority.Highest priority. Critical issue. P0 implies highest priority.

    on Jul 25, 2017
12. bjwatson commented on Jul 25, 2017

    

    bjwatson

    on Jul 25, 2017

    Last edited by bjwatson

    More actions

    @tseaver I'm discussing this with @lukesneeringer offline.
13. lukesneeringer commented on Jul 25, 2017

    

    lukesneeringer

    on Jul 25, 2017

    Contributor

    More actions

    Repeating this back to ensure I understand: Basically this is a situation where one call wraps the errors while others do not? Is this a configuration difference? Something else?
14. 17 remaining items

    Load more
15. bjwatson

    added

    release blockingRequired feature/issue must be fixed prior to next release.Required feature/issue must be fixed prior to next release.

    and removed

    priority: p0Highest priority. Critical issue. P0 implies highest priority.Highest priority. Critical issue. P0 implies highest priority.

    on Aug 7, 2017
16. lukesneeringer commented on Aug 8, 2017

    

    lukesneeringer

    on Aug 8, 2017

    Contributor

    More actions

    • Add google.api.core.exceptions #3738 is necessary but not sufficient.
    • GAX does not use Add google.api.core.exceptions #3738; @jonparrott will need to port that segment to google.api.core.
17. theacodes commented on Aug 8, 2017

    

    theacodes

    on Aug 8, 2017 via email

    Contributor

    More actions

    To further clarify: #3738 is sufficient to solve this specific case because spanner has significant manual code above the gapic, so the mapping can be done there. google.api.core will provide a iterator wrapper for unary-streaming that can be used by gapic.

    …

    On Mon, Aug 7, 2017, 7:07 PM Luke Sneeringer ***@***.***> wrote: - #3738 <#3738> is necessary but not sufficient. - GAX does not use #3738 <#3738>; @jonparrott <https://github.com/jonparrott> will need to port that segment to google.api.core. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3562 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUcxWbxhkKTuZQyhEuSHg4ZIlG08bQks5sV8LIgaJpZM4OIYWe> .
18. bjwatson commented on Aug 8, 2017

    

    bjwatson

    on Aug 8, 2017

    More actions

    Fixing this issue that's blocking Python Spanner Beta has the greatest urgency, so it's good to hear that #3738 is sufficient to fix it.

    That said, we'll need to fix this for GAPIC-only libraries. @jonparrott can you show @eoogbe what needs to be done to port your work to GAX, so that she's also familiar with the fix?
19. theacodes commented on Aug 8, 2017

    

    theacodes

    on Aug 8, 2017

    Contributor

    More actions

    Following up internally.
20. bjwatson commented on Aug 8, 2017

    

    bjwatson

    on Aug 8, 2017

    More actions

    Thanks for the update @jonparrott. I've responded internally.

    What needs to be done to close this specific issue for Spanner? Will you do it or should @tseaver?
21. theacodes commented on Aug 8, 2017

    

    theacodes

    on Aug 8, 2017

    Contributor

    More actions

    It's up to @tseaver (see here) but i'm happy to help.
22. bjwatson commented on Aug 8, 2017

    

    bjwatson

    on Aug 8, 2017

    More actions

    Thanks, Jon.
23. tseaver

    added a commit that references this issue on Aug 9, 2017

    Workaround for #3562.

    cf48b5e
24. tseaver commented on Aug 9, 2017

    

    tseaver

    on Aug 9, 2017

    Contributor

    More actions

    I will be merging the workaround in #3663 for spanner tonight.
25. bjwatson commented on Aug 9, 2017

    

    bjwatson

    on Aug 9, 2017

    More actions

    Thanks @tseaver!
26. tseaver commented on Aug 10, 2017

    

    tseaver

    on Aug 10, 2017

    Contributor

    More actions

    Via #3663.

    🎉React with 🎉1Reacted by Brian J. Watson
27. tseaver

    closed this as completedon Aug 10, 2017
28. theacodes

    unassigned

    evaogbe

    on Sep 28, 2018