Skip to content

Storage: un-skip system tests for 'Bucket.generate_signed_url' #7625

Closed

Description

@tseaver

Follow-on from PR #7460.

Currently, the GCS back-end has a bug for signed URLs against buckets: unlike blobs, which expect an appropriately-capitalized X-Goog-Signature query parameter, buckets want that parameter lower-cased. The system tests for signed bucket URLs are thus skipped in the PR, which is likely to merge before a back-end fix rolls out.

Once the fix is rolled up, remove the skips.

Activity

  1. added
    api: storageIssues related to the Cloud Storage API.
    type: processA process-related concern. May include testing, release, or the like.
    on Apr 1, 2019
  2. tseaver commented on Apr 1, 2019

    @tseaver
    ContributorAuthor
  3. frankyn commented on Apr 4, 2019

    @frankyn
    Contributor

    This is unblocked and can now be unskipped.

  4. changed the title [-]Storage: remove skipped system tests for 'Bucket.generate_signed_url'[/-] [+]Storage: un-skip system tests for 'Bucket.generate_signed_url'[/+] on Apr 16, 2019
  5. tseaver commented on Apr 17, 2019

    @tseaver
    ContributorAuthor

    8f2e13f in PR #7460 removes the skips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: storageIssues related to the Cloud Storage API.backendtestingtype: processA process-related concern. May include testing, release, or the like.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions