Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.
This repository was archived by the owner on May 6, 2026. It is now read-only.

Hapi: correctly extract url from request object #196

Closed
Closed
Hapi: correctly extract url from request object#196
Assignees
DominicKramer
Labels
🚨This issue needs some love.api: clouderrorreportingIssues related to the googleapis/nodejs-error-reporting API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@AdriVanHoudt
AdriVanHoudt
opened on Aug 21, 2018

If you are still having issues, please be sure to include as much information as
possible:

Environment details

  • OS: Mac/Linux
  • Node.js version: 8.11.4
  • npm version: 6.4.0
  • @google-cloud/error-reporting version: 0.5.1
  • hapi version: 16.x (<- probably the most important one :D)

Steps to reproduce

  1. Throw in request handler
  2. Error logged in cloud console is missing an url
    * image

This is due to

nodejs-error-reporting/src/request-extractors/hapi.ts

Line 90 in 259f04d

.setUrl(req!.url as {} as string)

req.url can be an URL object. I would suggest to fallback to req.path or req.url.path.
If that sounds ok I can do a PR if you'd like

Following these steps will guarantee the quickest resolution possible.

Thanks!

Activity

  1. JustinBeckwith
    added
    triage meI really want to be triaged.
    🚨This issue needs some love.
    on Aug 22, 2018

  2. DominicKramer commented on Aug 27, 2018

    @DominicKramer
    DominicKramer
    on Aug 27, 2018
    Contributor

    Thank you for opening this issue. On initial investigation, I agree that using req.url.pathname should be used if req.url is a URL object. Feel free to open a PR if you want to, but don't feel like you need to. We can take care of this too. Thanks.

  3. DominicKramer
    added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    and removed
    🚨This issue needs some love.
    triage meI really want to be triaged.
    on Aug 27, 2018

  4. AdriVanHoudt commented on Aug 28, 2018

    @AdriVanHoudt
    AdriVanHoudt
    on Aug 28, 2018
    Author

    I don't know typescript that well so not sure what as {} as string is doing so not sure what the quick fallback fix for this would be, thanks for picking this up!

  5. JustinBeckwith
    assigned
    DominicKramer
    on Sep 21, 2018
  6. ofrobots
    added 2 commits that reference this issue on Feb 12, 2019

    fix: properly handle hapi v16+ req.url

    f79fb9d

    fix: properly handle hapi v16+ req.url

    0c099af
  7. DominicKramer
    assigned
    ofrobots
    and unassigned
    DominicKramer
    on Feb 12, 2019
  8. DominicKramer
    closed this as completedin #311on Feb 12, 2019
  9. DominicKramer
    added a commit that references this issue on Feb 12, 2019

    fix: properly handle hapi v16+ req.url (#311)

    20868f0
  10. gcf-label-sync
    added
    api: clouderrorreportingIssues related to the googleapis/nodejs-error-reporting API.
    on Jan 31, 2020
  11. gcf-label-sync
    unassigned
    ofrobots
    on Jan 31, 2020
  12. yoshi-automation
    added
    🚨This issue needs some love.
    on Apr 7, 2020
  13. JustinBeckwith
    assigned
    DominicKramer
    on Feb 1, 2021
  14. GautamSharda
    added 2 commits that reference this issue on Jan 14, 2026

    fix: properly handle hapi v16+ req.url (#311)

    4f49684

    fix: properly handle hapi v16+ req.url (#311)

    d64576a
  15. GautamSharda
    added a commit that references this issue on Feb 5, 2026

    fix: properly handle hapi v16+ req.url (#311)

    9a96ac6
  16. GautamSharda
    added 2 commits that reference this issue on Feb 23, 2026

    fix: properly handle hapi v16+ req.url (#311)

    2097a18

    fix: properly handle hapi v16+ req.url (#311)

    b9cc808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: clouderrorreportingIssues related to the googleapis/nodejs-error-reporting API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions