Repository navigation
Conversation
…/3.2 - Override GrapheneEnumType.coerce_output_value alongside serialize so raw enum values and names coerce on graphql-core 3.3+. - Guard await in Schema.subscribe with inspect.isawaitable() to support graphql-core 3.3 async generator returns. - Relax graphql-core and graphql-relay upper bounds to <3.4 in setup.py. - Update version-sensitive GraphQLError message assertions in tests for graphql-core 3.2 and 3.3.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GrapheneEnumType.coerce_output_valuealongsideserialize(sharing_coerce_enum_value) so raw Python enum values and string names coerce cleanly ongraphql-core3.3+ while keeping 3.1/3.2 behavior unchanged.awaitinSchema.subscribewithinspect.isawaitable()to supportgraphql-core3.3 async generator returns.graphql-coreandgraphql-relaydependency bounds to<3.4insetup.py(addresses Will graphene support graphql-core 3.3? #1609).GraphQLErrorformatting assertions in the test suite based ongraphql.version_infoso tests pass on bothgraphql-core3.2 and 3.3.Verification
pytest -qwithgraphql-core==3.2.14(465 passed).pytest -qwithgraphql-core==3.3.2(465 passed).