Skip to content

Support graphql-core 3.3 while preserving 3.1 and 3.2 compatibility - #1613

Open
eldertek wants to merge 1 commit into
graphql-python:masterfrom
eldertek:fix/graphql-core-3-3-support
Open

eldertek wants to merge 1 commit into
graphql-python:masterfrom
eldertek:fix/graphql-core-3-3-support

Conversation

@eldertek

Copy link
Copy Markdown

Summary

  • Override GrapheneEnumType.coerce_output_value alongside serialize (sharing _coerce_enum_value) so raw Python enum values and string names coerce cleanly on graphql-core 3.3+ while keeping 3.1/3.2 behavior unchanged.
  • Guard await in Schema.subscribe with inspect.isawaitable() to support graphql-core 3.3 async generator returns.
  • Relax graphql-core and graphql-relay dependency bounds to <3.4 in setup.py (addresses Will graphene support graphql-core 3.3? #1609).
  • Update GraphQLError formatting assertions in the test suite based on graphql.version_info so tests pass on both graphql-core 3.2 and 3.3.

Verification

  • pytest -q with graphql-core==3.2.14 (465 passed).
  • pytest -q with graphql-core==3.3.2 (465 passed).

…/3.2

- Override GrapheneEnumType.coerce_output_value alongside serialize so raw enum values and names coerce on graphql-core 3.3+.
- Guard await in Schema.subscribe with inspect.isawaitable() to support graphql-core 3.3 async generator returns.
- Relax graphql-core and graphql-relay upper bounds to <3.4 in setup.py.
- Update version-sensitive GraphQLError message assertions in tests for graphql-core 3.2 and 3.3.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant