Repository navigation
Channelz should use milliseconds for timestamps #5494
Description
#4883 changed the TimeProvider.currentTimeNanos()'s precision to milliseconds, because there isn't a way to get the current time in nanoseconds precision. After #5056 is fixed, Channelz/ChannelTracer will be the only users of TimeProvider, and they all convert the time to proto Timestamp which doesn't mandate the unit. It will only be misleading to keep TimeProvider.currentTimeNanos() as is. It should be changed to currentTimeMillis().
Activity
carl-mastrangelo commentedon Mar 25, 2019
I'm going to disagree a little here. Two reasons:
dapengzhang0 commentedon Mar 29, 2019
One more factor to consider: the channelz service uses
timestamp.proto, so when you create a timestamp message, you have to use its nano precision API, and if you have a millis variable, you still have to cast it to nano at some point.vinodhabib commentedon Oct 4, 2024
Started Analysis and going through previous comments/details.
zhangkun83 commentedon Oct 4, 2024
I agree with @dapengzhang0's last comment. It is more convenient to use nanos to create
timestamp.prototimestamps. We can now changeSYSTEM_TIME_PROVIDERto use Java 8Instant.getNano()to get nano precision. I didn't find a way to get the current epoch nanos directly, so you'd still have to combine the seconds part and the nanos part fromInstant.ejona86 commentedon Oct 17, 2024
The TimeProvider API is already using nanos, so there's no change needed here. It's just what resolution the actual values use.
core: Make timestamp usage in Channelz use nanos from Java.time.Insta…