Skip to content

Fix typo in deprecated blocking stub javadoc. - #11772

Merged
larry-safran merged 1 commit into
grpc:masterfrom
benjaminp:stub-typo
Dec 26, 2024
Merged

larry-safran merged 1 commit into
grpc:masterfrom
benjaminp:stub-typo

Conversation

@benjaminp

Copy link
Copy Markdown
Contributor

No description provided.

@ejona86 ejona86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You noticed quickly 😄. Have you started playing with the new stub, or you just happened to notice the misspelling in passing?

@ejona86
ejona86 requested a review from larry-safran December 26, 2024 19:24
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 26, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 26, 2024
@benjaminp

Copy link
Copy Markdown
Contributor Author

I'm trying to use the new stubs. I hope there's a way for servers to do client-streaming RPCS in a blocking way in the works, too?

@larry-safran
larry-safran merged commit 8c261c3 into grpc:master Dec 26, 2024
@ejona86

ejona86 commented Dec 26, 2024

Copy link
Copy Markdown
Member

Excellent. We'd love to hear feedback about them.

We'd really like to do server-side, but there's some threading challenges. We need to run the service in a separate thread so we can receive onMessage/onReady callbacks. Ideally we'd also like to use the threadless executor for receiving callbacks (so we can avoid additional thread hops). I don't know of anyone that will have time soon to work on it.

@benjaminp
benjaminp deleted the stub-typo branch December 26, 2024 21:57
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants