Repository navigation
netty: move sslContext into transportCreationParamsFilterFactory - #3111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eagerly initializing
sslContext(#3060) can throw unnecessarily whenInternalNettyChannelBuilder#setDynamicTransportParamsFactoryhas been used to set a transport params factory. This PR introducesDefaultNettyTransportCreationParamsFilterFactory, and moves thefinal sslContextmember variable fromNettyTransportFactoryintoDefaultNettyTransportCreationParamsFilterFactory. This also moves the existing nestedDynamicNettyTransportParamsclass intoDefaultNettyTransportCreationParamsFilterFactory.Unfortunately, the git diff here is not very helpful with seeing the code movement.
I think this is a reasonable way to re-arrange things: we only use
sslContextif thetransportCreationParamsFilterFactoryparameter to theNettyTransportFactoryis null, in which case we create a newTransportCreationParamsFilterFactory, so it makes sense to movesslContextinto this new class.