Repository navigation
Conversation
|
cosmos review |
|
cosmos review |
|
Superseded by Himnish/cli#1 in native stack #6. All replacement layers passed GitHub CI. This branch and discussion are retained for reference. |
|
cosmos review |
There was a problem hiding this comment.
Review completed with 0 suggestions.
Reviewed commit: 3f0293c
GitHub could not attach the following findings inline to reviewed commit 3f0293c622c1fd3f5bf4db55bdb6e504adf07ef:
modules/aievals/skillmodule.go:24 — FormatSkillModule replaces tabs and newlines in the actual -skill path with spaces before putting it in the regeneration command. skillgen can read the original filename successfully, but rerunning the printed command can fail or read a different file.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
modules/aievals/skill_test.go:57 — TestPlaceSkillSkipsSymlinkedDetectedDirectory only covers a symlink that detectSkillDir rejects before it calls safeDetectedSkillPath. The test would still pass if validation of nested destination directories were removed, so it doesn't protect against a regression that writes the skill outside the repository.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
|
Addressed both findings in the review summary in
The skill package race tests passed. The canonical |
|
cosmos grammar-review |
|
|
||
| // Command skillgen copies the canonical AI Evals skill into a TypeScript module. | ||
| // It has no dependencies beyond the standard library and this module. | ||
| package main |
There was a problem hiding this comment.
It isn't wired into the harness binary, Who runs it, and where? It's weird to have a main file inside the module here.. I see if it is for creating a skill inside .cursor/ or .claude/, I suggest that it can be a command inside the cli to place that skill there...
There was a problem hiding this comment.
skillgen is just what I use to regenerate the PlatformUI copy from SKILL.md. Users don't run it. The command in #501 writes the embedded skill to the coding agent's skill directory or prints it.
Scope
modules/aievals/skill/SKILL.mdsource.Dependencies
Standalone; the runtime wiring PR consumes the exported skill placement API.
Verification
go test ./modules/aievals/...git diff --checkExplicit exclusions
No local-demo, source bootstrap, report persistence, metric advisor, JAX-RS, generated UI artifact, or unrelated docs.