Repository navigation
Omit sensitive_vars values from TF_LOG=debug output - #451
Merged
Merged
Conversation
heroku_config, heroku_app_config_association, and heroku_pipeline_config_var were logging the full contents of sensitive_vars maps. Log only the variable names so values are never written to debug output. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
mars
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the fix from #362 to the three resources it did not cover.
heroku_config,heroku_app_config_association, andheroku_pipeline_config_varwere logging the full contents ofsensitive_varsmaps when running withTF_LOG=debug, disclosing variable values in plaintext. This changes those log statements to output only the variable names, consistent with the behavior introduced in #362 forheroku_app.Changes
heroku_config—resourceHerokuConfigCreateandresourceHerokuConfigUpdateno longer log sensitive var valuesheroku_app_config_association—getSensitiveVarsandupdateVarsno longer log sensitive var valuesheroku_pipeline_config_var—resourceHerokuPipelineConfigVarReadandupdatePipelineConfigVarsno longer log sensitive var values