[markemer]

(edit by Pedro B.) Jira ticket: https://outsystemsrd.atlassian.net/browse/RMET-5448

[jcesarmobile]

it's still missing changes, like the ones in definitions.ts/README.md from https://github.com/ionic-team/capacitor-plugins/pull/2549/changes

For dependency installs use next tag, is picking nightly versions.

For the capacitor dependency keep the .package(url: "https://github.com/ionic-team/capacitor-swift-pm.git", from: "9.0.0-alpha.5") as we have done in all the other plugins for now, until we release the alpha 7. use .package(url: "https://github.com/ionic-team/capacitor.git", from: "9.0.0-alpha.7")

You have removed CapApp-SPM from the iOS native project, should be added back.

[jcesarmobile]

you have not addressed any of the comments I made on my last review, I've added a few more comments

would be good to separate the CI/release changes in a separate PR

[jcesarmobile]

not sure if you are doing the updates manually, but you are doing changes that should do and missing changes that should do.

run npx cap migrate on the example app and npx @capacitor/plugin-migration-v8-to-v9@latest in the plugin root and those should do any missing

the example app deployment target is set to $(RECOMMENDED_IPHONEOS_DEPLOYMENT_TARGET), which is 17.x, should be 16, that's whats making CI to fail, and npx cap migrate should fix the android failure too

[jcesarmobile]

while is not some missing change from the old repository, the new repo code has two "android 8+" mentions in code comments, those should be changed to just "android"

[jcesarmobile]

the example-app/package-lock.json is out of sync after the merge of #13, run npm install again from inside example-app folder

[OS-pedrogustavobilro]

I'm confused as to some changes you made to the release workflow. Is it still a WIP?

[jcesarmobile]

while is not some missing change from the old repository, the new repo code has two "android 8+" mentions in code comments, those should be changed to just "android"

this has not been addressed yet

[markemer]

while is not some missing change from the old repository, the new repo code has two "android 8+" mentions in code comments, those should be changed to just "android"

this has not been addressed yet

Done.

[jcesarmobile]

the plugin changes for https://outsystemsrd.atlassian.net/browse/RMET-5448 look good to me
I didn't review the CI changes since they are not relevant for RMET-5448