Skip to content

Unintended rollback patches #632

Closed
Closed

Description

@brussee

Applying a patch from a recipe with

self.apply_patch(join(self.get_recipe_dir(), 'use-soname.patch'), arch.arch)

Results every other build in an unintended rollback:

Reversed (or previously applied) patch detected!  Assuming -R.

Activity

  1. inclement commented on Feb 9, 2016

    @inclement
    Member

    Currently you should manually track whether the patch has already been applied, or use the patches attribute of the recipe to set the patches (in which case this is done, and the patches applied, automatically). If any existing recipe doesn't do this (are you looking at openssl?), it's a bug.

  2. kived commented on Feb 9, 2016

    @kived
    Contributor

    The patch in the openssl recipe is applied to files generated by the Configure script, which is why it runs unconditionally. Any patches applied via the patches class attribute are tracked and will only be applied once.

  3. brussee commented on Feb 9, 2016

    @brussee
    ContributorAuthor

    The patches can only be applied after a certain step in the recipe. When exactly are the patches = [] applied?

    Yes, as a matter of fact I took the openssl recipe as an example.

  4. kived commented on Feb 9, 2016

    @kived
    Contributor

    They are applied directly following prebuild_arch.

  5. brussee commented on Feb 9, 2016

    @brussee
    ContributorAuthor

    The patches can only be applied after a certain step in the recipe.

    Actually, the patches that are affected by the rollback can and should go in the patches = [].
    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions