Repository navigation
Conversation
Member
Author
|
Closing as a bad idea, or at least a bad implementation. I don't think we want to go this way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't really know if this is a good idea, but it seems like it could be. It's not for merging without some discussion and improvement.
I've tried to keep this POC simple. Basically, you run
p4a fetch_binary_diststo download some prebuilt dists from a github repo containing a basic index. p4a then downloads each one of these if there isn't already one with that name. After this, the dists behave exactly as normal and can be used to make APKs without any compiling.As a side effect, there's an
import_distcommand that's more general than this, so in principle (if you wanted to) it's easy for anyone to export and share dists they've built.Here's some sample output of running the commands: