Repository navigation
feat(oref): Hebrew→English location translations + breaking news integration - #661
Merged
Merged
Conversation
…ens into breaking news banner - Generate static location map from eladnava/pikud-haoref-api cities.json (1,478 entries) - Lazy-load translations in oref-alerts.ts with retry on failure - Add dispatchOrefBreakingAlert() with stable dedupe key and global cooldown bypass - Wire oref siren alerts into breaking news banner on initial fetch and polling updates
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
koala73
added a commit
that referenced
this pull request
Mar 1, 2026
…ens into breaking news banner (#661) - Generate static location map from eladnava/pikud-haoref-api cities.json (1,478 entries) - Lazy-load translations in oref-alerts.ts with retry on failure - Add dispatchOrefBreakingAlert() with stable dedupe key and global cooldown bypass - Wire oref siren alerts into breaking news banner on initial fetch and polling updates
matthewvecchione1-ops
pushed a commit
to matthewvecchione1-ops/worldmonitor
that referenced
this pull request
Mar 4, 2026
…ens into breaking news banner (koala73#661) - Generate static location map from eladnava/pikud-haoref-api cities.json (1,478 entries) - Lazy-load translations in oref-alerts.ts with retry on failure - Add dispatchOrefBreakingAlert() with stable dedupe key and global cooldown bypass - Wire oref siren alerts into breaking news banner on initial fetch and polling updates
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cities.jsonoref-alerts.tswith deduplicated in-flight promise and retry on failureDetails
Part 1 — Location translations: Oref alerts display "Rocket and missile fire" (translated) but all location names stay in Hebrew. The existing
STATIC_TRANSLATIONSmap only covers ~25 alert type phrases. This PR addstranslateLocation()backed by a 1,478-entry map (cities + zones), chained afterstaticTranslate()inapplyTranslations(). The AI fallback still runs for edge cases.Part 2 — Breaking news integration: Active oref siren alerts now dispatch a breaking news banner with
threatLevel: 'critical'andorigin: 'oref_siren'. Headline format:"Rocket and missile fire — Ashkelon, Tel Aviv, Haifa +15 areas". Bypasses global cooldown (real rocket alerts must never be suppressed by unrelated news) while still deduping per-event.Test plan
npx tsc --noEmit— 0 errorsnode --test tests/oref-locations.test.mjs tests/oref-breaking.test.mjs— 21/21 passnode --test tests/edge-functions.test.mjs— 30/30 pass