Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dropped ordinary activity hint currently makes the recovery feed incomplete for five minutes, but operators cannot distinguish it from a dropped read-error or slow-read hint. Add a bounded
lossobject with separate cumulative counters and recent-loss flags, plus per-snapshot skipped-shard, truncated-row, and concurrent-recording-loss diagnostics.The existing
completefield and its conservative coverage rules remain unchanged. The new independently sampled counters describe lost hints, not failed user requests or critical-only coverage. This changes only the recovery-signal module and its documentation; no deployment or rollout gate is changed.Validation:
cargo test -p lance-context-metrics --all-targets --locked(17 unit tests plus HTTP middleware integration test passed; manual throughput benchmark ignored), package formatting, andcargo clippy -p lance-context-metrics --all-targets --locked -- -D warnings. Regression coverage distinguishes ordinary-only loss with a preserved503, actual critical loss, slow404 classification, independently expiring loss windows, and response truncation.