Repository navigation
feat(wal): make the per-follower replication window configurable - #845
Conversation
beinan
left a comment
There was a problem hiding this comment.
Reviewed startup validation and application to every static voter before worker startup, including raft-rs capacity retention across progress resets. The per-follower/per-group tests exercise held replies, resumed durable commits, and reopening with a different window. Existing byte admission limits and the default window remain intact. No blocking findings. All three CI workflows passed for this commit.
beinan
left a comment
There was a problem hiding this comment.
Reviewed the current merge with main. The validated per-follower window is applied before workers start, preserves the default of 16, and leaves byte admission and quorum persistence boundaries unchanged. The tests cover bounded sends, resumption on durable replies, restart with a new window, and invalid values. Current-head WAL CI has passed; remaining CI is still running.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Problem
Runtime workers always use a 16-message follower window, so replication experiments cannot vary the amount of outstanding AppendEntries traffic independently of durable policy. Refs #378.
Fix
Add
runtime.raft_max_inflight_msgs(1–256, default 16) and apply it to every static voter before group workers start. Existing byte credits and uncommitted-byte limits remain authoritative. Changing the window on restart does not change the persisted policy.Verification
service, including blocked-sync elections and recovery.service(--all-targets -- -D warnings), workspace formatting andgit diff --checkpassed.