You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Makefile install_all should not install test binary #396
Checked that your issue isn't related to TomsFastMath's limitation that PK operations can by default only be done with max. 2048bit keys
Description
make -f makefile.shared install_all installs the test binary into $PATH, which then shadows coreutils test binary and causes problems. Generally installing a binary named test will cause some issues.
Jokes aside, we have the following set of demos etc.
aesgcm 2*
constants 1*
hashsum 2*
ltcrypt 2*
openssl-enc 2*
sizes 1*
small 0*
test 0*
timing 0*
tv_gen 0*
I've marked my opinion on their "install-worthiness"
As we had a nameclash for crypt which led us to rename it to ltcrypt we have the same for hashsum which we didn't resolve yet...
I'd say we should remove the possibility to install all "0*-rated" demos and the 1*- and 2*-rated demos should be renamed to something obvious e.g. ltcsizes and ltconstants. Then also regroup them... or don't use groups at all, but provide install-targets per binary?
If we keep groups:
demos - Builds 2*
bins - Builds 1* and 2*
all - Builds library, 0*, 1* and 2*
install_demos - Build&Install 2*
install_bins - Build&Install 1* and 2*
install_all - install install_bins install_doc (as before)
I agree with all of the above, also the renaming/prefixing with ltc is useful and should allow easy installing of those binaries into $PATH without name clashes. I also think grouping in Makefiles is useful and allows someone to easily play with the makefile so the demos should be regrouped.
IMO the only tool in "release quality" is hashsum and it is the only candidate worth installing. I am in doubts whether anybody will ever use make install_demos.
The ltcrypt + openssl-enc completely ignore integrity and aesgcm IMO needs a bit more work (we have discussed it in some other PR).
Activity
sjaeckel commentedon Jun 2, 2018
Isn't that kind of a 'feature' to have a good replacement in case your regular
testis defect? ;) </irony>J08nY commentedon Jun 2, 2018
I have fish shell, which for some reason, runs
testfrom $PATH, every timelsis run, so I was getting this:on every
lsrun, after installing libtomcrypt, that was quite weird and hard to debug 😄sjaeckel commentedon Jun 2, 2018
Jokes aside, we have the following set of demos etc.
I've marked my opinion on their "install-worthiness"
As we had a nameclash for
cryptwhich led us to rename it toltcryptwe have the same forhashsumwhich we didn't resolve yet...I'd say we should remove the possibility to install all "0*-rated" demos and the 1*- and 2*-rated demos should be renamed to something obvious e.g.
ltcsizesandltconstants. Then also regroup them... or don't use groups at all, but provide install-targets per binary?If we keep groups:
Please add your opinions & preferences! (ping @karel-m @buggywhip)
J08nY commentedon Jun 2, 2018
I agree with all of the above, also the renaming/prefixing with
ltcis useful and should allow easy installing of those binaries into $PATH without name clashes. I also think grouping in Makefiles is useful and allows someone to easily play with the makefile so the demos should be regrouped.Anyway, thanks for working on this issue! 👍
karel-m commentedon Jun 3, 2018
IMO the only tool in "release quality" is
hashsumand it is the only candidate worth installing. I am in doubts whether anybody will ever usemake install_demos.The
ltcrypt+openssl-enccompletely ignore integrity andaesgcmIMO needs a bit more work (we have discussed it in some other PR).The prefixing with
ltcis also not a bad idea.don't install `test` in target install_all
sjaeckel commentedon Jul 2, 2018
I'm reopening this so we can re-work as proposed.