Skip to content

ecc_import_pkcs8: fix error handling + memleak - #823

Merged
sjaeckel merged 1 commit into
developfrom
pr/fix-ecc_import_pkcs8-leak
Nov 18, 2026
Merged

sjaeckel merged 1 commit into
developfrom
pr/fix-ecc_import_pkcs8-leak

Conversation

@karel-m

@karel-m karel-m commented Nov 17, 2026

Copy link
Copy Markdown
Member

Fixes three errors:

  • ECParameters version other than 1: the import returned CRYPT_OK with an uninitialized key
  • field elements with unexpected ASN.1 types: the curve setup was skipped and ecc_set_key() then used the uninitialized key
  • invalid inner ECPrivateKey: the key was not freed, so every rejected key leaked memory

All three now return CRYPT_INVALID_PACKET and free the key where needed.

Tests use the existing long_pri_pkcs8 vector with one byte changed for each case.

@karel-m
karel-m requested a review from sjaeckel November 17, 2026 16:16
@sjaeckel
sjaeckel force-pushed the pr/fix-ecc_import_pkcs8-leak branch from 7e62cab to f7df4e1 Compare November 18, 2026 12:07
@sjaeckel
sjaeckel merged commit c5b6e06 into develop Nov 18, 2026
0 of 202 checks passed
@sjaeckel
sjaeckel deleted the pr/fix-ecc_import_pkcs8-leak branch November 18, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants