Skip to content

Toom cook 4 5 6 7 - #620

Open
czurnieden wants to merge 5 commits into
libtom:developfrom
czurnieden:toom_cook_4_5_6_7
Open

czurnieden wants to merge 5 commits into
libtom:developfrom
czurnieden:toom_cook_4_5_6_7

Conversation

@czurnieden

Copy link
Copy Markdown
Contributor

Addition of Toom-Cook 4, 5, 6, and 7-way.

The even versions do not work well with LibTomMath but YMMV. This is also one of the reasons there is no 8-way besides the constants in the interpolation phase were getting too large even for MP_32BIT.

Each stage has its own commit but might need fixes that were added later, please do a diff before you cherry-pick one. Sorry for that.

Some graphs (NTT added to show cutoff areas):

tc_2_7_ntt_mul

Multiplication (a * b with the x-axis showing the number of 60-bit limbs in a, y-axis the time in seconds, stepsize 1 (one)).

tc_2_7_ntt_sqr

Squaring (a^2 , the rest is the same as above)

@czurnieden

Copy link
Copy Markdown
Contributor Author

The tune test with valgrind timed out. As expected, to be honest, with four additional Toom-Cook benchmarks. Either remove the test completely (not recommended), tune the tune test (larger increments for this test?) or come up with something that actually works.
There is also PR #607 that allows for individual timeouts but one hour is way too long for a test that basically just tests test.c and not much more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant