Skip to content

Install rustls provider before VSS setup, enable ring feature - #1243

Merged
tankyleo merged 2 commits into
lightningdevkit:mainfrom
tnull:2026-11-vss-rustls-crypto-provider
Nov 18, 2026
Merged

tankyleo merged 2 commits into
lightningdevkit:mainfrom
tnull:2026-11-vss-rustls-crypto-provider

Conversation

@tnull

@tnull tnull commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Fixes #991

Workaround for now, real fix is upstream in rust-electrum-client.

@tnull tnull added this to the 0.8 milestone Nov 17, 2026
@tnull
tnull requested a review from tankyleo November 17, 2026 13:25
@ldk-reviews-bot

ldk-reviews-bot commented Nov 17, 2026 •

Copy link
Copy Markdown

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Comment thread tests/vss_crypto_provider_tests.rs Resolved
Comment thread src/io/vss_store.rs Resolved
The `rustls` `CryptoProvider` was only installed once the node itself
was built. However, setting up the VSS store happens before that and
already issues requests to the VSS server. If no provider had been
installed by then and both the `ring` and `aws-lc-rs` providers are
compiled in, `rustls` can't pick a default and panics on the first
TLS connection, failing the build of the node.

We now ensure the provider is installed before the VSS store is set
up. A provider previously installed by the application still takes
precedence.

Co-Authored-By: HAL 9000
We install the `ring`-based `CryptoProvider` ourselves, but only got
the corresponding `rustls` feature enabled through feature unification
with our dependencies. Any of them dropping the feature would have
broken our build.

We now enable the `ring` feature on our own `rustls` dependency.

Co-Authored-By: HAL 9000
@tnull
tnull force-pushed the 2026-11-vss-rustls-crypto-provider branch from fec9db0 to a3514ec Compare November 18, 2026 09:49
@tnull
tnull requested a review from tankyleo November 18, 2026 09:49
@tankyleo
tankyleo merged commit 3bc8309 into lightningdevkit:main Nov 18, 2026
14 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustls: dual-provider tree (ring + aws-lc-rs) has no process-level CryptoProvider default — panics on the VSS TLS path

3 participants