Repository navigation
Install rustls provider before VSS setup, enable ring feature - #1243
Merged
tankyleo merged 2 commits intoNov 18, 2026
Merged
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
tankyleo
reviewed
Nov 17, 2026
tankyleo
reviewed
Nov 17, 2026
The `rustls` `CryptoProvider` was only installed once the node itself was built. However, setting up the VSS store happens before that and already issues requests to the VSS server. If no provider had been installed by then and both the `ring` and `aws-lc-rs` providers are compiled in, `rustls` can't pick a default and panics on the first TLS connection, failing the build of the node. We now ensure the provider is installed before the VSS store is set up. A provider previously installed by the application still takes precedence. Co-Authored-By: HAL 9000
We install the `ring`-based `CryptoProvider` ourselves, but only got the corresponding `rustls` feature enabled through feature unification with our dependencies. Any of them dropping the feature would have broken our build. We now enable the `ring` feature on our own `rustls` dependency. Co-Authored-By: HAL 9000
tnull
force-pushed
the
2026-11-vss-rustls-crypto-provider
branch
from
November 18, 2026 09:49
fec9db0 to
a3514ec
Compare
tankyleo
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #991
Workaround for now, real fix is upstream in
rust-electrum-client.