Skip to content

Fix findRoute segfault - #118

Merged
arik-so merged 1 commit into
lightningdevkit:mainfrom
arik-so:arik/2023/09/find-route-segfault-fix
Sep 13, 2023
Merged

arik-so merged 1 commit into
lightningdevkit:mainfrom
arik-so:arik/2023/09/find-route-segfault-fix

Conversation

@arik-so

@arik-so arik-so commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@arik-so

arik-so commented Sep 13, 2023

Copy link
Copy Markdown
Contributor Author

This does introduce 5 new instances of direct leaks in the address sanitizer logs, but I don't know how to fix this differently. Ideas welcome @tnull :)

tnull
tnull previously approved these changes Sep 13, 2023

@tnull tnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Confirmed that test case reproduces the reported failure and is fixed by the given patch.
Unfortunately I don't have a good idea either, but leaking is always preferable over segfaulting...

Comment thread src/generation/base_type_generator.mts Resolved
@arik-so
arik-so force-pushed the arik/2023/09/find-route-segfault-fix branch from eed8878 to e03076f Compare September 13, 2023 08:40
@arik-so
arik-so merged commit f300e82 into lightningdevkit:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants