Skip to content

Improve block connection logging #2348

Open

Description

@TheBlueMatt

We regularly get users reporting issues with block sync (cause our API is a bit confusing, which desperately needs fixing by exposing the block sync crates to bindings users). These are quite hard to debug from our logs as our logs just aren't super detailed. We should log txids connected/confirmed as long as the list is small-ish, and maybe also log when we add things to the filter.

Activity

  1. added this to the 0.2 milestone on Jun 9, 2023
  2. Sharmalm commented on Sep 3, 2023

    @Sharmalm
    Contributor

    can i try this one?

  3. TheBlueMatt commented on Sep 3, 2023

    @TheBlueMatt
    CollaboratorAuthor

    Go for it. Should require carefully reading the block and transaction connection codepaths from ChannelManager and ChainMonitor all the way down and just ensuring that everything that happens gets logged but only once.

  4. Sharmalm commented on Sep 5, 2023

    @Sharmalm
    Contributor

    Could i get more information about codepath from channelManager and Chainmonitor , and how channelmaanger is accesing txids from chainmonitor .
    and also here 'txid' mentioned here is transaction id of funding transaction?

  5. TheBlueMatt commented on Sep 5, 2023

    @TheBlueMatt
    CollaboratorAuthor

    They're fully separate, called independently from LDK users' code.

  6. Sharmalm commented on Sep 7, 2023

    @Sharmalm
    Contributor

    Ok ,
    during constructing a channel message flow is - alice : open_channel , Bob : accept channel, alice : funding_created , bob : funding_signed and after funding_signed message funding_transaction broadcasted . so i have to log after funding signed message .

  7. TheBlueMatt commented on Sep 7, 2023

    @TheBlueMatt
    CollaboratorAuthor

    This issue is about the block connection, though, not the message handling flow. Block connection happens via transactions_confirmed/transactions_unconfirmed/block_connected/block_disconnected.

  8. malsomesh9 commented on Jan 31, 2026

    @malsomesh9

    Hi! I see this issue has been stale for a while. I'm a Summer of Bitcoin applicant and I'd like to pick this up and finish the work started by the previous contributor. I'll start by investigating the block_connected paths in ChannelManager. Is it okay if I take this over?

  9. malsomesh9 commented on Feb 1, 2026

    @malsomesh9

    Hi! I’m interested in working on this issue as part of my Bitcoin open-source learning.
    Could you please confirm if it’s still open and point me to relevant files?
    Thanks!

  10. added a commit that references this issue on Feb 13, 2026
    d79566b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions