You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Move tests in channelmanager.rs into more appropriate test files #2958
The channelmanager.rs file is huuuge³ at the moment and we shouldn't be adding more tests to it. We should move them into more appropriate test files (which may involve creating new _test.rs files too.
This is unlikely to create a ton of git noise as it should just be pure moves of tests so it could probably be done in one PR.
I would like to work on this issue, is this up for grabs?
Hey, thanks! It sure is! Let us know on this issue if you have any other questions while working on this. I'm not sure everything would move into existing test files so you may need to create some new ones that are more relevant but please feel free to ask!
Hey @srikanth-iyengar, those groupings seem to make sense to me from first glance! I think we can get some more comments on the moves int he PR to see it in context.
I started working on the issue, Currently I found that some of the fields/functions in the channel manager are private , should I make them public like pub(crate)?
Hi @TheBlueMatt, thank you for the go-ahead! Since #2977 is now closed, I'll be starting a fresh PR based on the current main branch to move the tests from channelmanager.rs cleanly. I'll link the new PR here once the initial work is ready for review
Hi @ektedar225 , just checking in are you still actively working on this? It's been a few months since your last update.
If you've moved on or paused this, I'd love to pick it up (using the old #2977 PR as a reference like you planned). @TheBlueMatt@dunxen , happy to take this over if it's free let me know and I'll get started right away.
Activity
srikanth-iyengar commentedon Mar 23, 2024
I would like to work on this issue, is this up for grabs?
dunxen commentedon Mar 23, 2024
Hey, thanks! It sure is! Let us know on this issue if you have any other questions while working on this. I'm not sure everything would move into existing test files so you may need to create some new ones that are more relevant but please feel free to ask!
srikanth-iyengar commentedon Mar 23, 2024
Yeah sure, will get back here if I face any issue
srikanth-iyengar commentedon Mar 26, 2024
Hey @dunxen I have analyzed the channelmanager tests and prepared the following test groups,
lemme know of your thoughts
There are total 22 tests
Group 1: Key Send and Payment Verification
Group 2: Channel Management and Limits
Group 3: Anchor Channel and Configuration Tests
dunxen commentedon Mar 27, 2024
Hey @srikanth-iyengar, those groupings seem to make sense to me from first glance! I think we can get some more comments on the moves int he PR to see it in context.
srikanth-iyengar commentedon Mar 28, 2024
I started working on the issue, Currently I found that some of the fields/functions in the channel manager are private , should I make them public like
pub(crate)?srikanth-iyengar commentedon Apr 1, 2024
Hey @dunxen I have raised a PR for this issue, Can you take a look ?
ektedar225 commentedon Feb 10, 2026
Hi @TheBlueMatt @valentinewallace,
I noticed that the previous PR #2977 for this issue has been inactive for a long time and has merge conflicts.
I would like to pick this up. My plan is to start fresh (using the old PR as a reference) to avoid conflict issues and move the tests cleanly.
Could you please assign this issue to me?
ektedar225 commentedon Feb 10, 2026
Hi @TheBlueMatt, thank you for the go-ahead! Since #2977 is now closed, I'll be starting a fresh PR based on the current main branch to move the tests from channelmanager.rs cleanly. I'll link the new PR here once the initial work is ready for review
Hamza1610 commentedon Jun 20, 2026
Hi @ektedar225, I noticed you took initiative in working on this issue, are you still on it?
Juwon-Ogunseye commentedon Aug 2, 2026
Hi @ektedar225 , just checking in are you still actively working on this? It's been a few months since your last update.
If you've moved on or paused this, I'd love to pick it up (using the old #2977 PR as a reference like you planned). @TheBlueMatt @dunxen , happy to take this over if it's free let me know and I'll get started right away.
valentinewallace commentedon Aug 12, 2026
@Juwon-Ogunseye go for it. Btw, this project has moved to Forgejo: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning