Skip to content

decode_onion_failure loggers dont have a payment hash #4307

Closed

Description

@TheBlueMatt

when we added a self logger in the outbound payment module we forgot to include the payment hash field in log calls esp onion failure decodes.

Activity

  1. added this to the 0.3 milestone on Jan 12, 2026
  2. TheBlueMatt commented on Jan 12, 2026

    @TheBlueMatt
    CollaboratorAuthor

    not sure if this is true on 0.1 as well but we should check.

  3. added 4 commits that reference this issue on Jan 25, 2026
    1a26355
    b949af6
    69ec1a1
    1c35beb
  4. TheBlueMatt commented on Jan 25, 2026

    @TheBlueMatt
    CollaboratorAuthor

    Dropping the backport 0.1 label as the upstream patch would require basically rewriting which is kinda bleh for a backport. This isn't that critical anyway.

  5. added a commit that references this issue on Jan 26, 2026
    8cc58e2
  6. TheBlueMatt commented on Jan 26, 2026

    @TheBlueMatt
    CollaboratorAuthor

    Planning to backport the fix pr in #4344

  7. added 10 commits that reference this issue on Jan 26, 2026
    a9f2601
    16ed8cf
    874e988
    eb99522
    d600dfe
    7dbbb5d
    75a39a0
    1683d8f
    9b673b7
    5e64c40
  8. added 2 commits that reference this issue on Jan 29, 2026
    ff07c70
    19259ea
  9. added a commit that references this issue on Feb 24, 2026
    4a47352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions