Repository navigation
chore(dep): temporary fix for fs-extra issue (to be reverted when fs-extra patches it) - #116
Merged
Merged
Conversation
…extra patches it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes log4js-node/log4js-node#1225
Instead of waiting for the next release
fs-extra, I took the liberty to defensively patch it instreamroller.This is an interim measure so that
streamrollercan be imported without errors from its nested dependencies.Currently, if
fs.realpath.nativeisundefined, the import ofstreamrollerwill fail because:streamrollerthrowing error (fromfs-extra)fs-extrathrowing errorfs.realpath.nativebeingundefinedOnce
fs-extrahas released the fixes, I will upgrade it and revert this defensive patch.