[devoto13]

To reduce amount of non critical dependencies given that readability and expressiveness is comparable.

I just noticed that this PR conflicts a bit with https://github.com/log4js-node/streamroller/tree/simplify branch. I can rebase it once simplify is merged.

It also looks like it will be rather easy to eliminate async from production dependencies.

What do you think about these changes?

[nomiddlename]

Thanks for taking a look at this. I'm in favour of removing lodash - it's a big dependency. I do like that fact that its functions are all null-safe though; it simplifies some of the code. I'll merge the simplify branch anyway, and you can take a look at your changes again.

[devoto13]

@nomiddlename I've pushed the update code. Please take a look.

PS On a side note these two tests failed on my machine because of different timezone.

[nomiddlename]

Thanks for this.

What timezone are you in, by the way? I'll see if I can make those tests a bit more reliable.

[devoto13]

I'm in Central European Summer Time (GMT+2). Did some experiments in REPL:

> const df = require('date-format')
> df.parse('yyyy-MM-dd', '2019-07-29', new Date(0))
2019-07-28T23:00:00.000Z
> new Date(2019, 6, 29)
2019-07-28T22:00:00.000Z
> df.parse('yyyy-MM-dd', '2019-07-29', new Date(0)).toLocaleString()
'7/29/2019, 1:00:00 AM'
> new Date(2019, 6, 29).toLocaleString()
'7/29/2019, 12:00:00 AM'
> new Date(0).toLocaleString()
'1/1/1970, 1:00:00 AM'
> new Date(0, 0).toLocaleString()
'1/1/1900, 12:00:00 AM'

Looks like the first offender is new Date(0), which treats timestamp as UTC instead of current timezone (date-format parses rest of the components as local timezone) and sets wrong value for hours because of the offset. So I guess first thing is to replace it with new Date(0, 0), which would set minimal values for all time components in current timezone to align behaviour with date-format.

Once this is fixed you can replace timestamps in tests with new Date(2019, 6, 29).getTime() to make tests not sensitive to the timezone.

[nomiddlename]

Published to NPM in v2.0.0