Skip to content

Lessen strictness of zlib tests #773

Closed

Description

@springmeyer

@flippmoke - looks like the nodejs core team decided NOT to rollback the zlib upgrade (nodejs/node#12404) so the problem at nodejs/node#12244 still holds.

I propose therefore adapting the node-mapnik tests to:

  • Stop comparing results between mapnik and node (or flip the one bit so that the tests pass)
  • Per earlier discussion, use the higher level zlib.inflate/deflate API (like this) rather than zlib.createGzip
  • Move .travis.yml and appveyor.yml to using latest version of v4, v6, v7, and v8 (rather than pinned versions)

Activity

  1. added this to the v3.6.1 milestone on May 31, 2017
  2. added a commit that references this issue on Jun 6, 2017
    82f2cc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions